Introducing assessments and assessmentsMetadata types #5649

chlahav · 2019-04-15T17:40:47Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-04-15T17:41:20Z

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: ['/usr/local/bin/autorest', '/tmp/tmp_fm5xnow/rest/specification/security/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpg3p0nx4l']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-04-15T17:41:21Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 322d3d62eb077ce48cbf2501ca4b7ecdf716da66
  stderr: 'fatal: reference is not a tree: 322d3d62eb077ce48cbf2501ca4b7ecdf716da66'

AutorestCI · 2019-04-15T17:41:37Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#2841

AutorestCI · 2019-04-15T17:42:05Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2019-04-15T17:43:17Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 322d3d62eb077ce48cbf2501ca4b7ecdf716da66
  stderr: 'fatal: reference is not a tree: 322d3d62eb077ce48cbf2501ca4b7ecdf716da66'

azuresdkci · 2019-04-15T17:56:27Z

Can one of the admins verify this patch?

jhendrixMSFT · 2019-04-15T18:21:38Z

@fearthecowboy I'm not sure what this modeler failure means, can you please elaborate? Oh ok I see, it's complaining because ResourceDetails contains no properties.

...ion/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessments.json

jhendrixMSFT

The following error needs to be fixed.
Swagger document contains two or more x-ms-enum extensions with the same name 'ReportedSeverity' and different values: Informational,Low,Medium,High vs. Compute,Network,Data,IdentityAndAccess,IoT

REST Spec PR 'Azure/azure-rest-api-specs#5649' REST Spec PR Author 'chlahav' REST Spec PR Last commit

chlahav · 2019-04-24T14:48:44Z

@jhendrixMSFT all you comments were resolved, can you please review again?

jhendrixMSFT · 2019-04-24T20:18:33Z

@chlahav for SDK this looks good, still need ARM to sign off. Have these APIs been deployed? We can't merge until they're live.

chlahav · 2019-04-28T15:41:54Z

@jhendrixMSFT these APIs are not exposed since we need ARM review to open them in the manifest.
after the ARM review we will expose the endpoint in the manifest, validate the quality and remove the DoNotMerge label so the PR will be completed

dsgouda · 2019-04-30T16:43:40Z

startbuild

REST Spec PR 'Azure/azure-rest-api-specs#5649' REST Spec PR Author 'chlahav' REST Spec PR Last commit

...icrosoft.Security/preview/2019-01-01-preview/examples/Assessments/GetAssessment_example.json

majastrz · 2019-05-07T21:27:47Z

...ion/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessments.json

+          "type": "string",
+          "description": "Human readable description for the reason the assessment result status"
+        },
+        "additionalData": {


additionalData [](start = 9, length = 14)

Are these known ahead of time or completely arbitrary? #Closed

completely arbitrary,
the set of additional data keys are decided per assessment (we have more than 50 assessments and growing) and currently the set is still changing for some of the assessments.
one day it might be more stable, but we will have more types than we can easily document #Closed

majastrz · 2019-05-07T21:32:23Z

...ion/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessments.json

+      "description": "Details of the resource that was assessed",
+      "discriminator": "assessedResourceSource",
+      "properties": {
+        "assessedResourceSource": {


assessedResourceSource [](start = 9, length = 22)

This should probably be an enum that only allows "Azure" as the value if you're using it as a discriminator. #Closed

done, also added OnPremise value because one valued enum is not included in the .Net ctors and creates a breaking change when the new value is added.
we will add the relevant OnPremiseResourceDetails before the completion of this PR, but we still need to work on them #Closed

majastrz

Can you take a look at my comments and questions?

dsgouda · 2019-05-08T21:59:10Z

startbuild

REST Spec PR 'Azure/azure-rest-api-specs#5649' REST Spec PR Author 'chlahav' REST Spec PR Last commit

adxsdknet · 2019-05-08T22:16:19Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6207
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@3a36eb3
adxsdknet/azure-sdk-for-net@0914506

chlahav · 2019-05-12T09:55:38Z

@majastrz the requested changes were pushed, can you please review?

REST Spec PR 'Azure/azure-rest-api-specs#5649' REST Spec PR Author 'chlahav' REST Spec PR Last commit

majastrz

Looks good.

jhendrixMSFT · 2019-05-15T16:41:01Z

Now that #5929 has been merged into master can you please merge master into your fork to pick up those changes?

jhendrixMSFT · 2019-06-17T16:54:22Z

@chlahav hello! What's the status of this PR?

chlahav · 2019-07-02T18:03:17Z

@chlahav hello! What's the status of this PR?

we are still working on validating the API,
it is still not ready to public preview yet so we don't want to merge it

we will update this PR right beforehand to save you guys unnecessary reviews

openapi-sdkautomation · 2019-07-31T13:00:19Z

In Testing, Please Ignore

[Logs] (Generated from 35998a7, Iteration 1)

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

preview/security/mgmt/v1.0 [Logs] [Instructions] [Generation PR]
- preview.security.mgmt.v1.0.zip
preview/security/mgmt/v2.0 [Logs] [Instructions] [Generation PR]
- preview.security.mgmt.v2.0.zip
preview/security/mgmt/v3.0 [Logs] [Instructions] [Generation PR]
- preview.security.mgmt.v3.0.zip

Python: Azure/azure-sdk-for-python [Logs] [Diff]

azure-mgmt-security [Logs] [Instructions] [Generation PR]
- azure-mgmt-security-0.2.0.zip
- azure_mgmt_security-0.2.0-py2.py3-none-any.whl

JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@azure/arm-security [Logs] [Instructions] [Generation PR]
- azure-arm-security-1.2.0.tgz

jhendrixMSFT · 2019-08-12T16:39:08Z

@chlahav is this ready yet? also note there are several merge conflicts that need to be resolved.

yungezz · 2019-08-15T01:42:55Z

@chlahav can we close the PR for now since you're not ready for merge, and the PR is over 4 months, there're lots of conflict with latest code base already. Pls create new PR when you're ready for review and merge.

jhendrixMSFT · 2019-08-20T21:34:09Z

Closing due to inactivity.

Chen Lahav added 2 commits March 20, 2019 15:30

Adding stable API version for Settings

a3a4b8b

Changing new version Settings file

35998a7

chlahav added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required DoNotMerge <valid label in PR review process> use to hold merge after approval labels Apr 15, 2019

azuresdkci assigned jhendrixMSFT Apr 15, 2019

azuresdkci requested a review from jhendrixMSFT April 15, 2019 17:52

jhendrixMSFT reviewed Apr 15, 2019

View reviewed changes

...ion/security/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessments.json Outdated Show resolved Hide resolved

chlahav force-pushed the master branch from 978418e to a09ca2f Compare April 17, 2019 11:30

jhendrixMSFT requested changes Apr 17, 2019

View reviewed changes

chlahav force-pushed the master branch from a09ca2f to 5853141 Compare April 17, 2019 18:27

AutorestCI mentioned this pull request Apr 17, 2019

[AutoPR security/resource-manager] Introducing assessments and assessmentsMetadata types Azure/azure-sdk-for-python#4886

Closed

chlahav requested a review from jhendrixMSFT April 17, 2019 18:28

AutorestCI mentioned this pull request Apr 17, 2019

[AutoPR security/resource-manager] Introducing assessments and assessmentsMetadata types Azure/azure-sdk-for-js#2322

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 17, 2019

.NET SDK Resource Provider:'SecurityCenter'

685d360

REST Spec PR 'Azure/azure-rest-api-specs#5649' REST Spec PR Author 'chlahav' REST Spec PR Last commit

chlahav force-pushed the master branch from 5853141 to b5988e0 Compare April 24, 2019 14:04

AutorestCI mentioned this pull request Apr 24, 2019

[AutoPR security/resource-manager] Introducing assessments and assessmentsMetadata types Azure/azure-sdk-for-js#2447

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 24, 2019

.NET SDK Resource Provider:'SecurityCenter'

4f2d05b

REST Spec PR 'Azure/azure-rest-api-specs#5649' REST Spec PR Author 'chlahav' REST Spec PR Last commit

chlahav force-pushed the master branch from b5988e0 to fa529ec Compare April 24, 2019 14:12

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 30, 2019

.NET SDK Resource Provider:'SecurityCenter'

eb2620d

REST Spec PR 'Azure/azure-rest-api-specs#5649' REST Spec PR Author 'chlahav' REST Spec PR Last commit

majastrz reviewed May 7, 2019

View reviewed changes

...icrosoft.Security/preview/2019-01-01-preview/examples/Assessments/GetAssessment_example.json Outdated Show resolved Hide resolved

majastrz reviewed May 7, 2019

View reviewed changes

majastrz requested changes May 7, 2019

View reviewed changes

majastrz added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 7, 2019

Azure deleted a comment from adxsdknet May 8, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 8, 2019

.NET SDK Resource Provider:'SecurityCenter'

3a36eb3

REST Spec PR 'Azure/azure-rest-api-specs#5649' REST Spec PR Author 'chlahav' REST Spec PR Last commit

chlahav force-pushed the master branch from 5401996 to b227f42 Compare May 12, 2019 09:43

AutorestCI mentioned this pull request May 12, 2019

[AutoPR security/resource-manager] Introducing assessments and assessmentsMetadata types Azure/azure-sdk-for-js#2841

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 12, 2019

.NET SDK Resource Provider:'SecurityCenter'

0914506

REST Spec PR 'Azure/azure-rest-api-specs#5649' REST Spec PR Author 'chlahav' REST Spec PR Last commit

majastrz approved these changes May 13, 2019

View reviewed changes

orparnes mentioned this pull request Jun 23, 2019

[DoNotMerge] Introducing subAssessments type (Microsoft.Security provider) #6422

Closed

5 tasks

chlahav force-pushed the master branch from b227f42 to 35998a7 Compare July 31, 2019 13:00

This was referenced Jul 31, 2019

[AutoPR security/resource-manager] Introducing assessments and assessmentsMetadata types Azure/azure-sdk-for-python#6573

Closed

[AutoPR security/resource-manager] Introducing assessments and assessmentsMetadata types Azure/azure-sdk-for-go#5393

Closed

openapi-sdkautomation bot mentioned this pull request Jul 31, 2019

[AutoPR @azure/arm-security] Introducing assessments and assessmentsMetadata types Azure/azure-sdk-for-js#4555

Closed

jhendrixMSFT closed this Aug 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introducing assessments and assessmentsMetadata types #5649

Introducing assessments and assessmentsMetadata types #5649

chlahav commented Apr 15, 2019

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

azuresdkci commented Apr 15, 2019

jhendrixMSFT commented Apr 15, 2019 •

edited

Loading

jhendrixMSFT left a comment

chlahav commented Apr 24, 2019

jhendrixMSFT commented Apr 24, 2019

chlahav commented Apr 28, 2019

dsgouda commented Apr 30, 2019

majastrz May 7, 2019 •

edited

Loading

chlahav May 12, 2019 •

edited by majastrz

Loading

majastrz May 7, 2019 •

edited

Loading

chlahav May 12, 2019 •

edited by majastrz

Loading

majastrz left a comment

dsgouda commented May 8, 2019

adxsdknet commented May 8, 2019 •

edited

Loading

chlahav commented May 12, 2019

majastrz left a comment

jhendrixMSFT commented May 15, 2019

jhendrixMSFT commented Jun 17, 2019

chlahav commented Jul 2, 2019

openapi-sdkautomation bot commented Jul 31, 2019 •

edited

Loading

jhendrixMSFT commented Aug 12, 2019

yungezz commented Aug 15, 2019 •

edited

Loading

jhendrixMSFT commented Aug 20, 2019

Introducing assessments and assessmentsMetadata types #5649

Introducing assessments and assessmentsMetadata types #5649

Conversation

chlahav commented Apr 15, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Apr 15, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Apr 15, 2019

jhendrixMSFT commented Apr 15, 2019 • edited Loading

jhendrixMSFT left a comment

Choose a reason for hiding this comment

chlahav commented Apr 24, 2019

jhendrixMSFT commented Apr 24, 2019

chlahav commented Apr 28, 2019

dsgouda commented Apr 30, 2019

majastrz May 7, 2019 • edited Loading

Choose a reason for hiding this comment

chlahav May 12, 2019 • edited by majastrz Loading

Choose a reason for hiding this comment

majastrz May 7, 2019 • edited Loading

Choose a reason for hiding this comment

chlahav May 12, 2019 • edited by majastrz Loading

Choose a reason for hiding this comment

majastrz left a comment

Choose a reason for hiding this comment

dsgouda commented May 8, 2019

adxsdknet commented May 8, 2019 • edited Loading

Automation for azure-sdk-for-net

chlahav commented May 12, 2019

majastrz left a comment

Choose a reason for hiding this comment

jhendrixMSFT commented May 15, 2019

jhendrixMSFT commented Jun 17, 2019

chlahav commented Jul 2, 2019

openapi-sdkautomation bot commented Jul 31, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from 35998a7, Iteration 1)

jhendrixMSFT commented Aug 12, 2019

yungezz commented Aug 15, 2019 • edited Loading

jhendrixMSFT commented Aug 20, 2019

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

AutorestCI commented Apr 15, 2019 •

edited

Loading

jhendrixMSFT commented Apr 15, 2019 •

edited

Loading

majastrz May 7, 2019 •

edited

Loading

chlahav May 12, 2019 •

edited by majastrz

Loading

majastrz May 7, 2019 •

edited

Loading

chlahav May 12, 2019 •

edited by majastrz

Loading

adxsdknet commented May 8, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jul 31, 2019 •

edited

Loading

yungezz commented Aug 15, 2019 •

edited

Loading